The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Apr 25, 2026 0:14am

@BugBot review

PR Summary

Medium Risk
Changes the executor’s streaming consumption/persistence path and adds new callback semantics; mistakes could truncate streamed outputs or skip memory persistence for agent runs. Scope is limited to streaming execution handling but affects a core runtime path.

Overview
Redesigns streaming handling to avoid Bun’s TransformStream memory/backpressure bug. BlockExecutor.handleStreamingExecution no longer tee()s and separately drains an executor stream; it now reads from a single ReadableStreamDefaultReader, forwards bytes to the client via a new ReadableStream, and accumulates decoded text only when the source fully drains.

Adds a new StreamingExecution.onFullContent hook and moves agent memory persistence to it. Agent streaming no longer wraps the source stream with a persistence TransformStream; instead it registers an onFullContent callback to append the final assistant message to memory after the stream completes. Streaming output assembly also now guards against persisting/trusting truncated content and logs when the client consumer exits early.

^{Reviewed by Cursor Bugbot for commit c6272d9. Bugbot is set up for automated code reviews on this repo. Configure here.}

@BugBot review

Greptile Summary

This PR fixes a Bun runtime memory leak (oven-sh/bun#28035) caused by TransformStream lacking backpressure signals. The fix removes wrapStreamForPersistence (which piped through a TransformStream) and replaces it with a pull-based ReadableStream that accumulates chunks inline, then delivers the assembled content via a new onFullContent callback on StreamingExecution after the stream fully drains.

Confidence Score: 5/5

Safe to merge; the fix correctly avoids the Bun TransformStream memory leak and all remaining findings are P2 style suggestions.

The core logic is sound: the pull-based approach eliminates the TransformStream, backpressure is correctly propagated, and edge cases (stream error, early consumer exit, empty content) are all guarded. The only finding is a minor inconsistency where onFullContent is called even when fullContent is empty, which is handled defensively by the agent handler today.

apps/sim/executor/execution/block-executor.ts — minor onFullContent guard inconsistency at line 718.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant AH as AgentHandler
    participant BE as BlockExecutor
    participant CS as clientSource (ReadableStream)
    participant PC as processedClientStream
    participant OS as onStream consumer

    AH->>BE: StreamingExecution { stream, execution, onFullContent }
    BE->>CS: Create pull-based ReadableStream (reads from sourceReader, accumulates chunks)
    BE->>PC: streamingResponseFormatProcessor.processStream(clientSource)
    BE->>OS: ctx.onStream({ stream: processedClientStream, execution })
    loop For each chunk
        OS->>PC: read chunk
        PC->>CS: pull
        CS->>CS: sourceReader.read() → decode → accumulated.push()
        CS-->>PC: enqueue(value)
        PC-->>OS: chunk
    end
    OS-->>BE: stream fully drained (sourceFullyDrained = true)
    BE->>BE: executionOutput.content = accumulated.join('')
    BE->>AH: onFullContent(fullContent)
    AH->>AH: memoryService.appendToMemory(ctx, inputs, { role: 'assistant', content })

_{Reviews (1): Last reviewed commit: "fix lint" | Re-trigger Greptile}